[webkit-reviews] review denied: [Bug 77712] [JSC] Range of cache flush is not guaranteed by Linux kernel : [Attachment 131268] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied hojong.han at samsung.com's request
for review:
Bug 77712: [JSC] Range of cache flush is not guaranteed by Linux kernel
https://bugs.webkit.org/show_bug.cgi?id=77712

Attachment 131268: Patch
https://bugs.webkit.org/attachment.cgi?id=131268&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131268&action=review


> Source/JavaScriptCore/jit/ExecutableAllocator.h:209
> +	       current = next;

You can eliminate the "next" variable if you change this line to "current +=
pageSize()".

> Source/JavaScriptCore/jit/ExecutableAllocator.h:211
> +	   } while (end >= current);

In C++, "end" traditionally means one-past-the-end. That's not the case here,
so I don't think you should use the word "end".

I'd suggest "currentPage" and "lastPage" for variable names.