[webkit-reviews] review denied: [Bug 80773] MathML crash in WebCore::Node::previousSibling() : [Attachment 131277] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 11:11:40 PDT 2012
Julien Chaffraix <jchaffraix at webkit.org> has denied Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 80773: MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773
Attachment 131277: The patch
https://bugs.webkit.org/attachment.cgi?id=131277&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131277&action=review
> Source/WebCore/rendering/RenderObject.cpp:272
> + if (!strcmp(renderName(), "RenderMathMLSubSup"))
First we *never* do a strcmp against renderName() and use a boolean function to
return this value (guarded by ENABLE(MATHML) in this case). Here this is a hack
and will not work if mtd is inserted below any other elements.
I would rather see a function introduced on RenderObject that returns whether
the table should be inlined or not. This will be needed for
https://bugs.webkit.org/show_bug.cgi?id=53144 AFAICT.
You will still have tons of issues (any table part <td>, <tr>, ... would
wrongly be wrapped in an inline table) but at least it's more correct.
More information about the webkit-reviews
mailing list