[webkit-reviews] review granted: [Bug 79636] Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl : [Attachment 131301] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 79636: Move Notifications APIs from DOMWindow.idl to
DOMWindowNotifications.idl
https://bugs.webkit.org/show_bug.cgi?id=79636

Attachment 131301: Patch
https://bugs.webkit.org/attachment.cgi?id=131301&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131301&action=review


Maybe the problem with mac is that the symbol is inside the
ENABLE(NOTIFICATIONS) block but needs to be outside?  That doesn't really make
sense though.  I'll look more carefully later today.

> Source/WebCore/notifications/DOMWindowNotifications.h:53
> +    void disconnectFrame();

I've been putting OVERRIDE on these since they're easy to break if this
function gets changed in the base class.