[webkit-reviews] review granted: [Bug 80484] Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly. : [Attachment 131275] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 80484: Remove CSSStyleSelector's convertToLength method and use
CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484

Attachment 131275: Patch
https://bugs.webkit.org/attachment.cgi?id=131275&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131275&action=review


> Source/WebCore/css/CSSPrimitiveValueMappings.h:3724
> +    if (((supported & FixedIntegerConversion) || (supported &
FixedFloatConversion)) && isFontRelativeLength() && (!style || !rootStyle))
> +	   return Length(Undefined);

>> Is NULL-checking for rootStyle also needed here?
> Yes it is, and this patch does. (See the last statement of this line.)

I didn't ask the question properly: the previous code was not NULL checking
|rootStyle| which is why I was asking if it was needed.