[webkit-reviews] review granted: [Bug 80658] Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale : [Attachment 131295] use setAttributeNodeNS

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 80658: Add tests for dynamic attribute changes for mapping of lang/xml:lang
to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658

Attachment 131295: use setAttributeNodeNS
https://bugs.webkit.org/attachment.cgi?id=131295&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I found Firefox computed language has the same behavior, with one change:
Firefox does not set xml:lang with setAttributeNode but does with
setAttributeNodeNS. It looks like it's incorrect to use setAttributeNode for
namespaced attributes, so I've revised the patch to use setAttributeNodeNS.

This sounds like a bug that needs to be fixed in WebKit, correct?