[webkit-reviews] review granted: [Bug 80830] Web Inspector: DebuggerModel.Location should have scriptId property. : [Attachment 131317] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 06:07:33 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80830: Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830

Attachment 131317: Patch
https://bugs.webkit.org/attachment.cgi?id=131317&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131317&action=review


> LayoutTests/inspector/debugger/raw-source-code.html:78
> +	   //InspectorTest.assertEquals(script.scriptId, location.scriptId);

Please uncomment this line.

> LayoutTests/inspector/debugger/raw-source-code.html:80
> +	   //InspectorTest.assertEquals(columnNumber, location.columnNumber);

ditto


More information about the webkit-reviews mailing list