[webkit-reviews] review denied: [Bug 79075] <style scoped>: Add @global rules : [Attachment 131005] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 04:10:58 PDT 2012


Antti Koivisto <koivisto at iki.fi> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 79075: <style scoped>: Add @global rules
https://bugs.webkit.org/show_bug.cgi?id=79075

Attachment 131005: Patch
https://bugs.webkit.org/attachment.cgi?id=131005&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I feel the scoped stylesheet feature is getting too complex and bloaty for
anyone to use effectively. If I understand correctly @global wouldn't be needed
in the first place if the spec wasn't limiting the selector matching to the
scope by default. It seems to me that just using explicit :scope ancestor for
scoped rules would achieve the same result with much less spec and
implementation bloat.

Since the required code changes are invasive, I don't think we should implement
any more of this feature until it is cleaned up.


More information about the webkit-reviews mailing list