[webkit-reviews] review granted: [Bug 80789] Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters : [Attachment 131257] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 80789: Web Inspector: TypeBuilder: Introduce OptOutput class for optional
output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Attachment 131257: Patch
https://bugs.webkit.org/attachment.cgi?id=131257&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131257&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.py:2244
> +class OptOutput {

Please make this class non-copyable to avoid passing it by value.

> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:67
> +static const InspectorFrontend::Debugger::Reason::Enum
domNativeBreakpointType = InspectorFrontend::Debugger::Reason::DOM;

Is there a reason for not inlining the new constant values?

> Source/WebCore/inspector/InspectorPageAgent.cpp:508
> +	   *cookiesString = "";

The protocol description says it should contain result of document.cookies even
if the cookies array is present. Please file a bug on this and put FIXME here.

> Source/WebCore/inspector/InspectorPageAgent.cpp:839
> +   
frameObject->setSecurityOrigin(frame->document()->securityOrigin()->toString())
;

Should this parameter be required if it is always present anyway? The type is
still hidden anyway so I think we may want to fix this.