[webkit-reviews] review canceled: [Bug 77835] [GObject bindings] Missing scope annotations for add/remove_event_listener : [Attachment 131002] Implements EventListeners by leveraging existing CodeGenerator

[bugzilla-daemon at webkit.org]

C Anthony <anthony at xtfx.me> has canceled C Anthony <anthony at xtfx.me>'s request
for review:
Bug 77835: [GObject bindings] Missing scope annotations for
add/remove_event_listener
https://bugs.webkit.org/show_bug.cgi?id=77835

Attachment 131002: Implements EventListeners by leveraging existing
CodeGenerator
https://bugs.webkit.org/attachment.cgi?id=131002&action=review

------- Additional Comments from C Anthony <anthony at xtfx.me>
this patch is an improvement on the last, and updated to r110399 (today-ish
IIRC)

things changed considerably since my original working tree -- i had to touch
many more files just to *allow* the IDL to be processed ... if i could get some
feedback ASAP that would be fantastic as im having difficulty keeping up with
the changes.

... who else needs to know or should be involved?  i want to be sure my work,
or others, are not in conflict.

testcases will be fixed once patch design is approved.
comments will be set to whatever you guys want.

PLEASE see the `handleEvent` except added to CodeGeneratorGObject.pm ... i dont
know how to handle this.  i tried using `Supplement`, ie. modifying IDL etc ...
not straight forward.  right now both the external and internal impls share the
same $interfaceName identifiers, so there is no clean way (AFAICS) for me to
operate as a "EventListener" externally (GObject/API), and a
GObjectEventlistener internally (WebCore) ...

all in all, i think it's pretty solid, and it does everything as advertised. 
will post a little demo app soon.

thoughts?