[webkit-reviews] review denied: [Bug 80802] Rename OptionsObject to V8Dictionary : [Attachment 131272] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied	review:
Bug 80802: Rename OptionsObject to V8Dictionary
https://bugs.webkit.org/show_bug.cgi?id=80802

Attachment 131272: Patch
https://bugs.webkit.org/attachment.cgi?id=131272&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
I found this renaming is wrong. As you can see in IDBObjectStore.h and
IDBKeyRange.h, WebCore is expecting that OptionsObject.h exists both in JSC and
in V8. OptionsObject.h should be a common interface between JSC and V8. So the
right fix would be

- to implement bindings/js/OptionsObject.h so that it has the same interface as
bindings/v8/OptionsObject.h. bindings/js/OptionsObject.h would be just a
wrapper of JSDictionary.
- to rename OptionsObject.{h,cpp} to Dictionary.{h,cpp}, for clarification.

The reason why IDBObjectStore.h and IDBKeyRange.h are not currently causing any
build errors is that IndexedDB is enabled in Chromium/V8 only.