[webkit-reviews] review denied: [Bug 80465] Integer overflow check code in arithmetic operation in classic interpreter : [Attachment 131274] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 22:17:15 PDT 2012


Gavin Barraclough <barraclough at apple.com> has denied SangGyu Lee
<sg5.lee at samsung.com>'s request for review:
Bug 80465: Integer overflow check code in arithmetic operation in classic
interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465

Attachment 131274: Patch
https://bugs.webkit.org/attachment.cgi?id=131274&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Sorry, still not quite there! - we need to check the top 17 bits are all zero -
we can ignore the bottom 15 bits.  So the shift count needs to be 15, not 17!


More information about the webkit-reviews mailing list