[webkit-reviews] review requested: [Bug 79611] Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map : [Attachment 131279] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 21:55:08 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 79611: Be more restrictive when adding ScrollableArea's to FrameView's
ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611

Attachment 131279: patch v1
https://bugs.webkit.org/attachment.cgi?id=131279&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Patch introduces a way to only cache actually scrollable
ScrollableArea-derivated instances (FrameView and RenderLayer).

For example, the added layout test counts for 36 scrollable areas with the
patch and around 90 without it. For real world webpages, I tested many ones,
including cnn.com main page, where it went from 11 scrollable areas cached to 0
(given that it has nothing actually scrollable, other than the mainframe).

This level of accuracy, allows ports to use this information for in-region
scroll target detection logic, etc.


More information about the webkit-reviews mailing list