[webkit-reviews] review granted: [Bug 79385] REGRESSION (r99369): File input button doesn't highlight when pressed : [Attachment 131195] Patch and layout tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 11 19:32:08 PDT 2012
Kent Tamura <tkent at chromium.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 79385: REGRESSION (r99369): File input button doesn't highlight when
pressed
https://bugs.webkit.org/show_bug.cgi?id=79385
Attachment 131195: Patch and layout tests
https://bugs.webkit.org/attachment.cgi?id=131195&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131195&action=review
> LayoutTests/fast/forms/file/file-input-pressed-state.html:7
> +<script>
> +if (window.layoutTestController)
> + layoutTestController.dumpAsText(true); // Dump pixel test result.
> +</script>
Inconsistent indentation. Another <script> block uses 4-space indentation.
We had better add a comment that we are not interested in a render tree dump in
this test.
More information about the webkit-reviews
mailing list