[webkit-reviews] review denied: [Bug 80465] Integer overflow check code in arithmetic operation in classic interpreter : [Attachment 131266] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 11 19:28:11 PDT 2012
Gavin Barraclough <barraclough at apple.com> has denied SangGyu Lee
<sg5.lee at samsung.com>'s request for review:
Bug 80465: Integer overflow check code in arithmetic operation in classic
interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465
Attachment 131266: Patch
https://bugs.webkit.org/attachment.cgi?id=131266&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
See my last comment, changing the value '15' to '16' is incorrect, you will
fail to detect overflow in the case of values such as 0xFFFF * 0xFFFF.
More information about the webkit-reviews
mailing list