[webkit-reviews] review granted: [Bug 80798] Web Inspector: WebKit1: update how the Web Inspector resources are loaded : [Attachment 131263] Proposed Change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 17:58:27 PDT 2012


Brian Weinstein <bweinstein at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 80798: Web Inspector: WebKit1: update how the Web Inspector resources are
loaded
https://bugs.webkit.org/show_bug.cgi?id=80798

Attachment 131263: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=131263&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131263&action=review


> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:166
> +	   ![[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"]
pathForResource:@"Main" ofType:@"html"];

Should we save this result into a static so we don't have to compute this each
time?


More information about the webkit-reviews mailing list