[webkit-reviews] review denied: [Bug 80787] Provide access to process private and shared memory size : [Attachment 131226] Patch for landing

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 80787: Provide access to process private and shared memory size
https://bugs.webkit.org/show_bug.cgi?id=80787

Attachment 131226: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=131226&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131226&action=review


> Source/WebCore/page/MemoryInfo.cpp:53
>	   : m_totalJSHeapSize(0),
>	     m_usedJSHeapSize(0),
> -	     m_jsHeapSizeLimit(0)
> +	     m_jsHeapSizeLimit(0),
> +	     m_processPrivateMemorySize(0),
> +	     m_processSharedMemorySize(0)

This initializer list isn't in the correct style.  The "," should be vertically
aligned with the ":"

> Source/WebCore/page/MemoryInfo.idl:42
> +	   readonly attribute unsigned long long processPrivateMemorySize;
> +	   readonly attribute unsigned long long processSharedMemorySize;

Should these APIs only be exposed in PLATFORM(CHROMIUM) since they'll always be
zero elsewhere?  Should we implement them on other platforms as well?  Is there
a spec somewhere for this interface?