[webkit-reviews] review denied: [Bug 80504] Web Inspector: console.log attempts to substitute any "%" character in the message. : [Attachment 130592] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 11 05:08:53 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 80504: Web Inspector: console.log attempts to substitute any "%" character
in the message.
https://bugs.webkit.org/show_bug.cgi?id=80504
Attachment 130592: Patch
https://bugs.webkit.org/attachment.cgi?id=130592&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130592&action=review
> Source/WebCore/inspector/front-end/utilities.js:811
> + if (!(format[index] in formatters)) {
This will break strings like "foo%555 bar"
More information about the webkit-reviews
mailing list