[webkit-reviews] review granted: [Bug 80784] Web Inspector: [chromium] add provisional test for the downstream sanity test. : [Attachment 131211] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 01:30:26 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 80784: Web Inspector: [chromium] add provisional test for the downstream
sanity test.
https://bugs.webkit.org/show_bug.cgi?id=80784

Attachment 131211: Patch
https://bugs.webkit.org/attachment.cgi?id=131211&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131211&action=review


> Source/WebKit/chromium/src/js/Tests.js:590
> +	       ++matchesCount;

Please use 2 booleans to check that you receive both log and error messages.


More information about the webkit-reviews mailing list