[webkit-reviews] review denied: [Bug 80760] WinLauncher should show loading errors : [Attachment 131180] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 21:45:32 PST 2012


Brent Fulgham <bfulgham at webkit.org> has denied Ashod Nakashian
<ashodnakashian at yahoo.com>'s request for review:
Bug 80760: WinLauncher should show loading errors
https://bugs.webkit.org/show_bug.cgi?id=80760

Attachment 131180: Patch
https://bugs.webkit.org/attachment.cgi?id=131180&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131180&action=review


This change includes a lot of white-space modifications. While I agree with
these changes, they cause the actual patch to be hard to review due to clutter
in the ChangeLog and other areas.

Please generate a patch with the functional change, and a second patch (if you
are so inclined), and I'll be happy to approve them separately.

> Tools/WinLauncher/WinLauncher.cpp:150
> +    ::MessageBoxW(0, (LPCWSTR)errorDescription, L"Error", MB_APPLMODAL |
MB_OK);

This should be a C++ cast, even though much of the rest of the file still uses
C-style casts.


More information about the webkit-reviews mailing list