[webkit-reviews] review canceled: [Bug 43022] 100% height elements to not respond to vertical browser rescaling : [Attachment 131086] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 43022: 100% height elements to not respond to vertical browser rescaling
https://bugs.webkit.org/show_bug.cgi?id=43022

Attachment 131086: Patch
https://bugs.webkit.org/attachment.cgi?id=131086&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131086&action=review


The change and test looks very good. However
tables/mozilla_expected_failures/bugs/bug85016.html has a different output.
This test uses percent height too so it's likely not a coincidence. If this is
a progression, I would need to see a rebaseline on at least one platform and a
proper disabling on all platforms. If it's a regression, well, it should be
solved.

> LayoutTests/fast/replaced/vertical-resize-100percent-element.html:48
> +    if (window.layoutTestController)
> +	   layoutTestController.notifyDone();

No need for the waitUntilDone() / notifyDone(). By default DRT dumps after the
load event and you add those only if you need to continue after.