[webkit-reviews] review requested: [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units : [Attachment 131175] Patch-With-Abstract-Interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 09:31:00 PST 2012


Joe Thomas <joethomas at motorola.com> has asked  for review:
Bug 27160: Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

Attachment 131175: Patch-With-Abstract-Interface
https://bugs.webkit.org/attachment.cgi?id=131175&action=review

------- Additional Comments from Joe Thomas <joethomas at motorola.com>
Added Abstract interface class for fetching the Viewport size.

I ran Parser/html5-full-render on Mac Snow-Leopard with webkit revision r110376
with and without the new patch and below are the values

Webkit rev 110376 - {16540.5ms, 16448ms, 16431ms, 16506.5ms, 16580ms}

Webkit rev 110376 with Patch - {16463ms, 16517.5ms, 16593ms, 16543ms, 16506ms}


The values looks more or less same in Mac SL but there is a variation of around
150-200 ms. Is it possible test the patch on performance bots for any possible
regressions?


More information about the webkit-reviews mailing list