[webkit-reviews] review denied: [Bug 80477] Add Notification constructor : [Attachment 131155] new Notification(title, body, iconURL)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 03:23:31 PST 2012


Kentaro Hara <haraken at chromium.org> has denied Jon Lee <jonlee at apple.com>'s
request for review:
Bug 80477: Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477

Attachment 131155: new Notification(title, body, iconURL)
https://bugs.webkit.org/attachment.cgi?id=131155&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131155&action=review


> Source/WebCore/ChangeLog:8
> +

Would you please add the link to the spec that supports this change?

> Source/WebCore/notifications/Notification.idl:38
> +	   Constructor(in DOMString title, in DOMString body, in
[Optional=DefaultIsUndefined] DOMString iconUrl),

This constructor signature is different from the spec:
http://www.w3.org/TR/notifications/#notification-constructor


More information about the webkit-reviews mailing list