[webkit-reviews] review granted: [Bug 80734] [V8] Fix a fixme in v8 bindings and inline fast case for toInt32 and toUInt32 : [Attachment 131119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 15:11:10 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 80734: [V8] Fix a fixme in v8 bindings and inline fast case for toInt32 and
toUInt32
https://bugs.webkit.org/show_bug.cgi?id=80734

Attachment 131119: Patch
https://bugs.webkit.org/attachment.cgi?id=131119&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
This change looks good in that it removes FIXME. But basically I wanted to see
some performance tests (e.g. "XXX becomes YYY% faster") if you intend to make
some performance optimization (i.e. inlining). We are likely to make wasteful
"optimization".


More information about the webkit-reviews mailing list