[webkit-reviews] review granted: [Bug 77049] [Chromium] Force compositeAndReadback through regular scheduling flow : [Attachment 131007] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 77049: [Chromium] Force compositeAndReadback through regular scheduling
flow
https://bugs.webkit.org/show_bug.cgi?id=77049

Attachment 131007: Patch
https://bugs.webkit.org/attachment.cgi?id=131007&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131007&action=review


Very nice! I think we have a wee bit o' a memory leak, but easily fixable.

R=me

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:397
> +    m_pendingBeginFrameRequest = new BeginFrameAndCommitState();

if we schedule a begin frame from the impl thread, but then start a shutdown
from the main thread before we process the message will we end up leaking this
pointer?  maybe m_pendingBeginFrameRequest should be an OwnPtr<> member - i
think if we have to shut down the compositor with a beginFrame pending the
right thing to do is to free up its memory and just don't worry about the
scroll offsets/etc on it