[webkit-reviews] review denied: [Bug 80706] Improve ContainerNode's collectNodes() performance : [Attachment 131081] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 80706: Improve ContainerNode's collectNodes() performance
https://bugs.webkit.org/show_bug.cgi?id=80706

Attachment 131081: Patch
https://bugs.webkit.org/attachment.cgi?id=131081&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131081&action=review


> Source/WebCore/ChangeLog:9
> +	   Covered by existing tests.

You need to explain what tests this improves performance on.

> Source/WebCore/dom/ContainerNode.cpp:66
> +    nodes.reserveCapacity(nodes.size() + node->childNodeCount());

I believe childNodeCount() walks all the node pointers... but I could imagine
avoiding multiple mallocs would be faster.

> Source/WebCore/dom/ContainerNode.cpp:77
> -    collectNodes(node, nodes);
> +    collectNodes(static_cast<ContainerNode*>(node), nodes);

This doesn't seem safe.