[webkit-reviews] review denied: [Bug 80705] Simplify memory usage tracking in CopiedSpace : [Attachment 131048] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 80705: Simplify memory usage tracking in CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=80705

Attachment 131048: Patch
https://bugs.webkit.org/attachment.cgi?id=131048&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131048&action=review


> Source/JavaScriptCore/heap/CopiedSpace.cpp:245
> +size_t CopiedSpace::totalMemoryAllocated()

Is this function used anywhere? I don't see its use inside JavaScriptCore.

> Source/JavaScriptCore/heap/CopiedSpace.cpp:268
> +    for (CopiedBlock* block =
static_cast<CopiedBlock*>(m_fromSpace->head()); block; block =
static_cast<CopiedBlock*>(block->next()))

I don't think it's right to count from space toward utilization. Only to space
contains utilized memory.

> Source/JavaScriptCore/heap/CopiedSpace.h:69
> +    size_t totalMemoryAllocated();
> +    size_t totalMemoryUtilized();

Our typical names for these concepts are "size" and "capacity".