[webkit-reviews] review denied: [Bug 80706] Improve ContainerNode's collectNodes() performance : [Attachment 131065] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 11:56:15 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 80706: Improve ContainerNode's collectNodes() performance
https://bugs.webkit.org/show_bug.cgi?id=80706

Attachment 131065: Patch
https://bugs.webkit.org/attachment.cgi?id=131065&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131065&action=review


> Source/WebCore/dom/ContainerNode.cpp:78
> -    collectNodes(node, nodes);
> +    if (!node->isContainerNode())
> +	   return;

node is a DocumentFragment (which inherits from ContainerNode) at this point so
there's no need to call isContainerNode.


More information about the webkit-reviews mailing list