[webkit-reviews] review canceled: [Bug 80671] Split the extra logical height distribution logic out of RenderTableSection::layoutRows : [Attachment 130956] Proposed refactoring.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 11:49:21 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 80671: Split the extra logical height distribution logic out of
RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=80671

Attachment 130956: Proposed refactoring.
https://bugs.webkit.org/attachment.cgi?id=130956&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130956&action=review


>> Source/WebCore/rendering/RenderTableSection.cpp:511
>> +	    remainingExtraLogicalHeight =
distributeExtraLogicalHeightToAutoRows(remainingExtraLogicalHeight,
autoRowsCount);
> 
> The previous code had checks for totalPercent == 0 and autoRowsCount == 0,
which avoided a needless iteration through all of the rows.  Is that worth
keeping?

Yes, autoRowsCount == 0 is handled inside
distributeExtraLogicalHeightToAutoRows, however I forgot to keep the
totalPercent check while cleaning the code. As a side note, a table usually
doesn't have a lot of sections AFAICT but it's better not to slow down in case
it does.


More information about the webkit-reviews mailing list