[webkit-reviews] review granted: [Bug 80027] [chromium] Increase size of Combo Box Options for touch and high DPI devices : [Attachment 130614] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 9 11:49:08 PST 2012
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tim Dresser
<tdresser at chromium.org>'s request for review:
Bug 80027: [chromium] Increase size of Combo Box Options for touch and high DPI
devices
https://bugs.webkit.org/show_bug.cgi?id=80027
Attachment 130614: Patch
https://bugs.webkit.org/attachment.cgi?id=130614&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130614&action=review
Switch the 'const int scale' to just 'int scale', and then R=me
> Source/WebCore/platform/chromium/PopupListBox.cpp:356
> + const int scale = m_settings.defaultDeviceScaleFactor;
nit: no need for 'const' in front of int here. it is unnecessary verbosity.
we usually only write 'const int' when giving a name to an int literal.
More information about the webkit-reviews
mailing list