[webkit-reviews] review canceled: [Bug 78491] [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+ : [Attachment 131037] Patch Proposal + Unit Tests + Docs

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 78491: [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=78491

Attachment 131037: Patch Proposal + Unit Tests + Docs
https://bugs.webkit.org/attachment.cgi?id=131037&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch fixing the coding style issue in GRefPtr.h and explaining
better the meaning of 'selected files' in the documentation.

For ease of review, I paste here the diff between this patch related to that
explanation:

@@ -168,7 +168,7 @@ static void
webkit_file_chooser_request_class_init(WebKitFileChooserRequestClass
      * WebKitFileChooserRequest:selected-files:
      *
      * A %NULL-terminated array of strings containing the list of
-     * selected files currently associated to the request. See
+     * selected files associated to the current request. See
      * webkit_file_chooser_request_get_selected_files() for more details.
      */
     g_object_class_install_property(objectClass,
@@ -212,7 +212,9 @@ gboolean
webkit_file_chooser_request_allows_multiple_selection(WebKitFileChooser
  * Get the list of MIME types the file chooser dialog should handle,
  * in the format specified in RFC 2046 for "media types". Its contents
  * depend on the value of the 'accept' attribute for HTML input
- * elements.
+ * elements. This function should normally be called before presenting
+ * the file chooser dialog to the user, to decide whether to allow the
+ * user to select multiple files at once or only one.
  *
  * Returns: (array zero-terminated=1) (transfer none): a
  * %NULL-terminated array of strings if a list of accepted MIME types
@@ -250,7 +252,10 @@ const gchar* const*
webkit_file_chooser_request_get_mime_types(WebKitFileChooser
  *
  * Get the filter currently associated with the request, already set
  * up with the list of MIME types as returned by
- * webkit_file_chooser_request_get_mime_types().
+ * webkit_file_chooser_request_get_mime_types(). This function should
+ * normally be called before presenting the file chooser dialog to the
+ * user, to decide whether to apply a filter so the user would not be
+ * allowed to select files with other MIME types.
  *
  * Returns: (transfer none): a #GtkFileFilter if a list of accepted
  * MIME types is defined or %NULL otherwise. The returned object is
@@ -315,9 +320,16 @@ void
webkit_file_chooser_request_choose_files(WebKitFileChooserRequest* request,
  * @request: a #WebKitFileChooserRequest
  *
  * Get the list of selected files currently associated to the
- * request. This list will normally be empty with the first
- * request and will contain the list of files previously selected,
- * if any, in further requests over the same HTML input Element.
+ * request. This list will normally be empty with the first request
+ * and will contain the list of files previously selected, if any, in
+ * further requests over the same HTML input Element. It's important
+ * to notice that this list won't change for the current request after
+ * making a new selection, since it does not represent the list of
+ * files being selected but those that might be associated to the
+ * request at the moment it gets triggered. Thus, this function should
+ * normally be called only before presenting the file chooser dialog
+ * to the user, probably to decide whether to perform some extra
+ * action, like getting those files in the list pre-selected.
  *
  * Returns: (array zero-terminated=1) (transfer none): a
  * %NULL-terminated array of strings if there are selected files