[webkit-reviews] review granted: [Bug 80701] getCueAsHTML() should return different fragments : [Attachment 131036] Fixed method and added test

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<vcarbune at adobe.com>'s request for review:
Bug 80701: getCueAsHTML() should return different fragments
https://bugs.webkit.org/show_bug.cgi?id=80701

Attachment 131036: Fixed method and added test
https://bugs.webkit.org/attachment.cgi?id=131036&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131036&action=review


Nice fix and terrific test - thanks!

> Source/WebCore/html/track/TextTrackCue.cpp:362
> +    RefPtr<DocumentFragment> clonedFragment;
> +    Document* document;

Nit: There is no need to declare these here and initialize them further down in
the function. No need to have this block landing the fix, but lets fix it the
next time we modify this file.