[webkit-reviews] review denied: [Bug 80696] Remove custom bindings for attribute type Array. : [Attachment 131028] proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 80696: Remove custom bindings for attribute type Array.
https://bugs.webkit.org/show_bug.cgi?id=80696

Attachment 131028: proposed patch
https://bugs.webkit.org/attachment.cgi?id=131028&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131028&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1774
> +				   push(@implContent, "    const
Vector<RefPtr<ScriptProfile> > vector = impl->$implGetterFunctionName();\n\n");


Why ScriptProfile?  Shouldn't it depend on the type?  This doesn't seem right.

Also, is the name "Array" used in the specs?  I thought WebIDL used syntax like
DOMString[] that give the type of the array.

> Source/WebCore/page/Console.idl:49
> -	   readonly attribute [CustomGetter] Array profiles;
> +	   readonly attribute Array profiles;

This change affects JSC and V8 but you've only change the CodeGeneratorJS and
not CodeGeneratorV8.