[webkit-reviews] review granted: [Bug 80042] [WK2] run-perf-tests should be able to run with WTR : [Attachment 130183] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 09:04:58 PST 2012

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 80042: [WK2] run-perf-tests should be able to run with WTR

Attachment 130183: Patch

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130183&action=review

> Tools/WebKitTestRunner/TestController.cpp:558
> +	   timeout = -1.0;
> +	   break;
> +    }

Sorry, I should have been a bit clearer in my review comment. I think it makes
sense to have a constant, perhaps a static member variable like:

TestController:s_noTimeoutDuration = -1;

I can change this and land it.

More information about the webkit-reviews mailing list