[webkit-reviews] review denied: [Bug 79601] [EFL] [DRT] Implement scheduleAsynchronousKeyDown. : [Attachment 130807] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 79601: [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=79601

Attachment 130807: Patch
https://bugs.webkit.org/attachment.cgi?id=130807&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130807&action=review


> Tools/DumpRenderTree/efl/EventSender.cpp:463
> +    OwnPtr<KeyEventInfo> keyEventInfo = createKeyEventInfo(context,
argumentCount, arguments, exception);

This will need the adoptPtr(), see bellow.

> Tools/DumpRenderTree/efl/EventSender.cpp:464
> +    sendKeyDown(evas_object_evas_get(browser->mainFrame()),
keyEventInfo.release());

This should be keyEventInfo.get()

> Tools/DumpRenderTree/efl/EventSender.cpp:543
> +    sendKeyDown(evas_object_evas_get(browser->mainFrame()),
keyEventInfo.release());

This should be keyEventInfo.get().

> Tools/DumpRenderTree/efl/EventSender.cpp:550
> +    OwnPtr<KeyEventInfo> keyEventInfo = createKeyEventInfo(context,
argumentCount, arguments, exception);
> +    ecore_idler_add(sendAsynchronousKeyDown,
static_cast<void*>(keyEventInfo.leakPtr()));

Churn =( I think it makes more sense to have createKeyEventInfo return a normal
pointer, you're essentially not using this OwnPtr here.