[webkit-reviews] review granted: [Bug 80680] Move WTF-related Windows project files out of JavaScriptCore : [Attachment 130998] Patch

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 80680: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

Attachment 130998: Patch
https://bugs.webkit.org/attachment.cgi?id=130998&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130998&action=review


Do we need to worry about this working with build-webkit? Eric's comment in
https://bugs.webkit.org/show_bug.cgi?id=80553#c13 implies that it wouldn't work
yet.

r=me (assuming it doesn't screw up build-webkit)

> Source/WTF/WTF.vcproj/work-around-vs-dependency-tracking-bugs.py:11
> +TOP_LEVEL_DIRECTORY =
os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath
(__file__)))))

Why is calling dirname no longer necessary here?