[webkit-reviews] review requested: [Bug 80690] [BlackBerry] Web Notification not working after rebase : [Attachment 131022] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 03:09:35 PST 2012


Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 80690: [BlackBerry] Web Notification not working after rebase
https://bugs.webkit.org/show_bug.cgi?id=80690

Attachment 131022: Patch
https://bugs.webkit.org/attachment.cgi?id=131022&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
With this patch, we did:

1. Namespace of NotificationPresenterImpl moved from WebKit to WebCore. All
code in WebCoreSupport should be in the namespace of WebCore.
2. Remove the un-needed ChromeClientBlackBerry::notificationPresenter
3. Connect the NotificationPresenter to WebCore using
WebCore::provideNotification(Page*, NotificationPresenter*).


More information about the webkit-reviews mailing list