[webkit-reviews] review granted: [Bug 79886] ShadowRoot should have activeElement : [Attachment 130803] Updated Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 79886: ShadowRoot should have activeElement
https://bugs.webkit.org/show_bug.cgi?id=79886

Attachment 130803: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=130803&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130803&action=review


> Source/WebCore/dom/ShadowRoot.cpp:165
> +Element* ShadowRoot::activeElement() const
> +{
> +    if (document()->isHTMLDocument())
> +	   return treeScope()->activeElement();
> +    return 0;
> +}

I think it'll be better to make this function inline so that we don't introduce
a new function call in Document::activeElement.

> Source/WebCore/dom/TreeScope.cpp:179
> +    // If treeScope becomes document, document->shadowHost() fails. As
toElement(0) throws ASSERT.

I think this comment is more confusing than helpful. Please remove.