[webkit-reviews] review denied: [Bug 80650] [WebSocket] Add a layout test where server force to disable all extensions : [Attachment 130940] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 80650: [WebSocket] Add a layout test where server force to disable all
extensions
https://bugs.webkit.org/show_bug.cgi?id=80650

Attachment 130940: Patch
https://bugs.webkit.org/attachment.cgi?id=130940&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130940&action=review


>
LayoutTests/http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt
:7
> +PASS ws.extensions is ""
> +PASS ws.extensions is ""
> +PASS ws.extensions is ""

It's hard to understand what are tested here with this result. At least we
should show:

Check the value before opening the connection:
PASS ws.extensions is ""
PASS ws.extensions = "foo"; ws.extensions is ""
Check the value after opening the connection:
PASS ws.extensions is ""

> LayoutTests/http/tests/websocket/tests/hybi/echo-with-no-extension.html:21
> +ws.extensions = "foo";
> +shouldBeEqualToString("ws.extensions", "");

I prefer shouldBeEqualToString("ws.extensions = 'foo'; ws.extensions", "");

> LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt:7
>  PASS ws.extensions is ""
>  PASS ws.extensions is ""
> +PASS ws.extensions is "x-webkit-deflate-frame"

I'd like to make the same comment with echo-with-no-extension-expected.txt.