[webkit-reviews] review granted: [Bug 80657] Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build : [Attachment 130941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 17:54:49 PST 2012


Jessie Berlin <jberlin at webkit.org> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 80657: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for
Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657

Attachment 130941: Patch
https://bugs.webkit.org/attachment.cgi?id=130941&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130941&action=review


r=me.

Hopefully bfulgham will get a chance to take a look at it before you commit it.


>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:34
> +				CompileAsManaged=""

Do we know why this section got added? It looks like it got pulled into the
vcproj from the JavaScriptCoreGeneratedCommon.vsprops file.

I think the addition of this sections should probably be reverted. Otherwise,
future changes to the vsprops files might not have any effect.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:53
> +				CompileAsManaged=""

Ditto.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:72
> +				CompileAsManaged=""

Ditto.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:91
> +				CompileAsManaged=""

Ditto.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:110
> +				CompileAsManaged=""

Ditto.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:129
> +				CompileAsManaged=""

Ditto.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenera
ted.vcproj:148
> +				CompileAsManaged=""

Ditto.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:34
> +				CompileAsManaged=""

I think the same goes for this section. It looks like it is covered by the
WTFGeneratedCommon.vsprops.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:53
> +				CompileAsManaged=""

Ditto.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:72
> +				CompileAsManaged=""

Ditto.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:91
> +				CompileAsManaged=""

Ditto.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:110
> +				CompileAsManaged=""

Ditto.

> Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:129
> +				CompileAsManaged=""

Ditto.


More information about the webkit-reviews mailing list