[webkit-reviews] review granted: [Bug 80207] Fix IndexedDB build with JSC : [Attachment 130300] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 80207: Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207

Attachment 130300: Patch
https://bugs.webkit.org/attachment.cgi?id=130300&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130300&action=review


I was hoping some of the IDB folks would review your patch, but this looks fine
to me.

> Source/WebCore/bindings/js/SerializedScriptValue.h:66
> -class SerializedScriptValue : public RefCounted<SerializedScriptValue> {
> +class SerializedScriptValue :
> +#if ENABLE(INDEXED_DATABASE)
> +    public ThreadSafeRefCounted<SerializedScriptValue> {
> +#else
> +    public RefCounted<SerializedScriptValue> {
> +#endif

Should we just make this always ThreadSafeRefCounted ?	Having this ifdef seems
scary.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3058
> +    if ($globalObject) {

Do we need to run-bindings-tests --reset-results after this change to the code
generator?