[webkit-reviews] review denied: [Bug 80631] Implement selectedOptions attribute of <select>. : [Attachment 130888] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 8 17:08:37 PST 2012
Benjamin Poulain <benjamin at webkit.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 80631: Implement selectedOptions attribute of <select>.
https://bugs.webkit.org/show_bug.cgi?id=80631
Attachment 130888: Patch
https://bugs.webkit.org/attachment.cgi?id=130888&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The patch looks good.
I would add test coverage for:
-disabled option
-disabled select
-nested <select> :-D ... something like this:
<select>
<option>
<select>
<option selected>
</select>
</option>
<option></option>
</selection>
-multiple selected options for a select without "multiple"
More information about the webkit-reviews
mailing list