[webkit-reviews] review granted: [Bug 72411] No-op filter changes color output because of colorspace issues : [Attachment 130883] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 14:19:07 PST 2012


Dean Jackson <dino at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 72411: No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411

Attachment 130883: patch
https://bugs.webkit.org/attachment.cgi?id=130883&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130883&action=review


This looks fine to me. Are you going to send another patch with the skips or
test_expectations?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:124
> +    // FIXME: Windows should be able to use linear sRGB, this is tracked by
http://webkit.org/b/80000.

I protest that such a nice id is for such a boring bug


More information about the webkit-reviews mailing list