[webkit-reviews] review requested: [Bug 72411] No-op filter changes color output because of colorspace issues : [Attachment 130883] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 12:48:57 PST 2012


Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 72411: No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411

Attachment 130883: patch
https://bugs.webkit.org/attachment.cgi?id=130883&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
This patch differs from the last only slightly:

-    if (iccProfileURL && !CFURLCreateDataAndPropertiesFromResource(0,
iccProfileURL.get(), &iccProfileData, 0, 0, 0))
+    if (iccProfileURL && CFURLCreateDataAndPropertiesFromResource(0,
iccProfileURL.get(), &iccProfileData, 0, 0, 0))

I'd misread the CFURL docs when reorganizing this function and got the expected
return value swapped.

So, now it's just up to the tests.


More information about the webkit-reviews mailing list