[webkit-reviews] review denied: [Bug 80626] [chromium] Only build NEON files if target_arch=="arm" : [Attachment 130874] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 80626: [chromium] Only build NEON files if target_arch=="arm"
https://bugs.webkit.org/show_bug.cgi?id=80626

Attachment 130874: Patch
https://bugs.webkit.org/attachment.cgi?id=130874&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130874&action=review


> Source/WebCore/ChangeLog:9
> +	   Currently, webcore_arm_neon will compile a bunch of files
> +	   whose contents are completely ifdef'd away on non-arm, and
> +	   then bundle all the generated empty .o files into a useless
> +	   libwebcore_arm_neon.a. Don't do this.

This change seems fine since we're not using the lib at all.

> Source/WebCore/ChangeLog:12
> +	   Also change the source section from "include everything, then
> +	   throw away everything except 6 files" to "list 6 files".

I don't like this because this means we have a file list in two places
(confusing for non-chromium people adding new files).  The current design is to
have all the files listed WebCore.gypi.  Another way to do this would be to
make a new variable in WebCore.gypi that lists the NEON files.