[webkit-reviews] review granted: [Bug 80338] Add a method to window.internals to enable testing of inspector highlight rects : [Attachment 130636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 11:52:57 PST 2012


Pavel Feldman <pfeldman at chromium.org> has granted Max Vujovic
<mvujovic at adobe.com>'s request for review:
Bug 80338: Add a method to window.internals to enable testing of inspector
highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338

Attachment 130636: Patch
https://bugs.webkit.org/attachment.cgi?id=130636&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130636&action=review


This looks great, thanks for implementing it!

> LayoutTests/inspector/elements/highlight-node.html:4
> +	       body {

Nit: we typically don't indent head / style tags (see other tests).

> LayoutTests/inspector/elements/highlight-node.html:46
> +		       InspectorTest.completeTest();

Nit: you should run InspectorTest.completeTest() from within the callback of
the evaluate above.


More information about the webkit-reviews mailing list