[webkit-reviews] review granted: [Bug 77668] [chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded : [Attachment 130847] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 77668: [chromium] Ensure that the cc thread animation framework continues
to tick when the tab is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=77668

Attachment 130847: Patch
https://bugs.webkit.org/attachment.cgi?id=130847&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130847&action=review


R=me w/ nits

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:44
> +const double lowFrequencyAnimationInterval = 0.3;

we tick setTimeout()s at 1Hz for background tabs, can we use the same value for
this?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:50
> +class CCLayerTreeHostImplTimeSourceAdapter : public CCTimeSourceClient {
> +public:

add WTF_MAKE_NONCOPYABLE as well to hide copy/assignment c'tors

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:73
> +    explicit CCLayerTreeHostImplTimeSourceAdapter(CCLayerTreeHostImpl*
layerTreeHostImpl, PassRefPtr<CCDelayBasedTimeSource> timeSource)

now you don't need explicit (since it's a 2-arg c'tor). Isn't C++ fun?