[webkit-reviews] review granted: [Bug 80590] [Qt] Use Qt's module system for install rules and depending on QtWebKit : [Attachment 130850] with changelog, ready for review

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Tor Arne Vestbø
<vestbo at webkit.org>'s request for review:
Bug 80590: [Qt] Use Qt's module system for install rules and depending on
QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=80590

Attachment 130850: with changelog, ready for review
https://bugs.webkit.org/attachment.cgi?id=130850&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130850&action=review


r=me with comments

>> ChangeLog:1
>> +2012-03-08	Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

I agree with the style queue here, would be nice to have the url to bugzilla
here and in the other ChangeLogs when landing.

> Source/api.pri:38
> +    # to a bogus patch in default_pre.prf.

patch -> path

> Source/api.pri:58
> +	   make_module_fwd_symlink.target =
$$convenience_module_path/$$module_filename
> +	   make_module_fwd_symlink.commands = $$QMAKE_MKDIR
$$convenience_module_path \
> +	       && $(SYMLINK) $$QMAKE_EXTRA_MODULE_FORWARDS/$$module_filename
$$convenience_module_path
> +	   make_module_fwd_symlink.depends =
$$QMAKE_EXTRA_MODULE_FORWARDS/$$module_filename

I suppose this is going to require a copy instead of symlink on Windows?

A cross-platform alternative would be to put a .pri file there that includes
the real .pri file - a poor man's symlink :)

> Tools/qmake/mkspecs/features/default_post.prf:147
> +contains(QT, webkit) {
> +    haveQt(4) {
> +	   # Qt 4 still uses custom rules to depend on QtWebKit
> +	   load(qtwebkit)
> +    }

Neat trick to make this work with the Qt 4 build :)