[webkit-reviews] review granted: [Bug 80584] [chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status : [Attachment 130804] null check during initialize
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 8 11:09:20 PST 2012
James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 80584: [chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of
LRC initialization status
https://bugs.webkit.org/show_bug.cgi?id=80584
Attachment 130804: null check during initialize
https://bugs.webkit.org/attachment.cgi?id=130804&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130804&action=review
OK
> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:399
> + if (visible && m_layerRenderer &&
m_layerRenderer->capabilities().usingPartialSwap)
since we're also null checking m_layerRenderer on line 394 probably better to
just null check it and return above that line instead of checking it twice
More information about the webkit-reviews
mailing list