[webkit-reviews] review denied: [Bug 80573] Support [Custom] for static functions : [Attachment 130781] Patch made with -w

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Jon Lee <jonlee at apple.com>'s
request for review:
Bug 80573: Support [Custom] for static functions
https://bugs.webkit.org/show_bug.cgi?id=80573

Attachment 130781: Patch made with -w
https://bugs.webkit.org/attachment.cgi?id=130781&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130781&action=review


Just an out-of-curious question: What method wants to use [Custom] static?

> Source/WebCore/ChangeLog:32
> +	   * bindings/scripts/test/JS/JSTestObj.cpp:
> +	   (WebCore):
> +	   (WebCore::jsTestObjConstructorFunctionClassMethod2):
> +	   * bindings/scripts/test/JS/JSTestObj.h:
> +	   (JSTestObj):
> +	   (WebCore):
> +	   * bindings/scripts/test/ObjC/DOMTestObj.h:
> +	   * bindings/scripts/test/ObjC/DOMTestObj.mm:
> +	   (-[DOMTestObj classMethod2]):
> +	   * bindings/scripts/test/V8/V8TestObj.cpp:
> +	   (WebCore::ConfigureV8TestObjTemplate):
> +	   * bindings/scripts/test/V8/V8TestObj.h:
> +	   (V8TestObj):

It seems you also touched CodeGenerator{V8,ObjC}.pm, but they are not included
in this patch. Would you please update the patch correctly? BTW, don't we need
to modify CodeGenerator{GObject,CPP}.pm?