[webkit-reviews] review denied: [Bug 80136] [EFL][DRT] Implement LayoutTestController's methods related with editing : [Attachment 130568] rebased patch to HEAD

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 80136: [EFL][DRT] Implement LayoutTestController's methods related with
editing
https://bugs.webkit.org/show_bug.cgi?id=80136

Attachment 130568: rebased patch to HEAD
https://bugs.webkit.org/attachment.cgi?id=130568&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130568&action=review


> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:235
> +    m_smartInsertDeleteEnabled = enabled;

You also need to set m_selectTrailingWhitespaceEnabled false if enabled was
true here.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:245
> +    m_selectTrailingWhitespaceEnabled = enabled;

You need to set m_smartInsertDeleteEnabled false if enabled was true here.